Bug 64287

Summary: Web Inspector: Network panel search needs each resource to have unique identifier.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch with fixes
none
Patch with fixes2 none

Vsevolod Vlasov
Reported 2011-07-11 09:18:38 PDT
Network panel search needs each resource to have unique identifier.
Attachments
Patch (6.45 KB, patch)
2011-07-11 09:23 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch with fixes (6.40 KB, patch)
2011-07-12 06:10 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch with fixes2 (6.38 KB, patch)
2011-07-12 06:30 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-07-11 09:23:43 PDT
Created attachment 100310 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-07-12 05:08:22 PDT
Comment on attachment 100310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100310&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1158 > + if (this._matchedResourcesMap[resource.identifier]) { > + this._matchedResourcesMap[oldResource.identifier] = this._matchedResourcesMap[resource.identifier]; > + delete this._matchedResourcesMap[resource.identifier]; > + } > + for (var i = 0; i < this._matchedResources.length; i++) { > + if (this._matchedResources[i] === resource.identifier) > + this._matchedResources[i] = oldResource.identifier; > + } As far as the value in this._matchedResourcesMap[resource.identifier] is the index of resource in this._matchedResources you can use it instead of iterating over this._matchedResources array.
Vsevolod Vlasov
Comment 3 2011-07-12 06:10:03 PDT
Created attachment 100474 [details] Patch with fixes
Vsevolod Vlasov
Comment 4 2011-07-12 06:30:08 PDT
Created attachment 100477 [details] Patch with fixes2
WebKit Review Bot
Comment 5 2011-07-13 07:02:40 PDT
Comment on attachment 100477 [details] Patch with fixes2 Clearing flags on attachment: 100477 Committed r90913: <http://trac.webkit.org/changeset/90913>
WebKit Review Bot
Comment 6 2011-07-13 07:02:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.