| Summary: | Cleanup TilingData::textureOffset | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Reveman <reveman> | ||||||
| Component: | New Bugs | Assignee: | David Reveman <reveman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | enne, jamesr, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
David Reveman
2011-07-10 14:02:26 PDT
Created attachment 100237 [details]
Patch
Attachment 100237 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 100238 [details]
Patch
Comment on attachment 100238 [details]
Patch
What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures?
At any rate, this looks fine to me.
(In reply to comment #4) > (From update of attachment 100238 [details]) > What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures? The texture offset previously depended on the tile index. This is not the case since r90646. Landed r90653 Friday as a minimal change to just fix the build. This is just a proper cleanup of that change. Comment on attachment 100238 [details] Patch Clearing flags on attachment: 100238 Committed r90886: <http://trac.webkit.org/changeset/90886> All reviewed patches have been landed. Closing bug. |