Bug 64245

Summary: Cleanup TilingData::textureOffset
Product: WebKit Reporter: David Reveman <reveman>
Component: New BugsAssignee: David Reveman <reveman>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Reveman
Reported 2011-07-10 14:02:26 PDT
Cleanup TilingData::textureOffset
Attachments
Patch (2.85 KB, patch)
2011-07-10 14:03 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2011-07-10 14:07 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Reveman
Comment 1 2011-07-10 14:03:32 PDT
Created attachment 100237 [details] Patch
WebKit Review Bot
Comment 2 2011-07-10 14:06:17 PDT
Attachment 100237 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Reveman
Comment 3 2011-07-10 14:07:24 PDT
Created attachment 100238 [details] Patch
Brent Fulgham
Comment 4 2011-07-10 18:46:57 PDT
Comment on attachment 100238 [details] Patch What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures? At any rate, this looks fine to me.
David Reveman
Comment 5 2011-07-10 18:59:32 PDT
(In reply to comment #4) > (From update of attachment 100238 [details]) > What were the two indices used for previously? Was the original design such that the tiling data would hold multiple textures? The texture offset previously depended on the tile index. This is not the case since r90646. Landed r90653 Friday as a minimal change to just fix the build. This is just a proper cleanup of that change.
WebKit Review Bot
Comment 6 2011-07-12 22:13:10 PDT
Comment on attachment 100238 [details] Patch Clearing flags on attachment: 100238 Committed r90886: <http://trac.webkit.org/changeset/90886>
WebKit Review Bot
Comment 7 2011-07-12 22:13:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.