Bug 64244

Summary:

WebSocket: Add useHixie76Protocol flag to WebSocketChannel and WebSocketHandshake

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

WebCore Misc.

Assignee:

Yuta Kitamura <yutak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

50099

Attachments:

Description	Flags
Patch	none

Description Yuta Kitamura 2011-07-10 12:26:39 PDT

This is the first step of bug 50099.

Comment 1 Yuta Kitamura 2011-07-10 12:40:21 PDT

Created attachment 100236 [details]
Patch

Comment 2 Kent Tamura 2011-07-10 18:22:34 PDT

Comment on attachment 100236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100236&action=review

> Source/WebCore/websockets/WebSocketHandshake.cpp:162
> -WebSocketHandshake::WebSocketHandshake(const KURL& url, const String& protocol, ScriptExecutionContext* context)
> +WebSocketHandshake::WebSocketHandshake(const KURL& url, const String& protocol, ScriptExecutionContext* context, bool useHixie76Protocol)

We usually avoid a bool argument. But I think it's acceptable in this case because we have no callers with literal false/true.

Comment 3 WebKit Review Bot 2011-07-10 19:04:45 PDT

Comment on attachment 100236 [details]
Patch

Clearing flags on attachment: 100236

Committed r90704: <http://trac.webkit.org/changeset/90704>

Comment 4 WebKit Review Bot 2011-07-10 19:04:50 PDT

All reviewed patches have been landed.  Closing bug.