| Summary: | WebKit2 is leaking NSCursors created by leakNamedCursor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-07-10 11:30:54 PDT
Created attachment 100233 [details]
Patch
Wouldn’t it be better to cache each of these NSCursor objects exactly once? Except for the custom cursor one? (In reply to comment #2) > Wouldn’t it be better to cache each of these NSCursor objects exactly once? We're already caching them in the Cursor singletons in WebKit1, and for WebKit2 that's what the forcing of platformCursor does. I don't like the idea of having three levels of caches for some Cursors (WKSI, CursorMac.mm and Cursor.cpp). (In reply to comment #4) > for WebKit2 that's what the forcing of platformCursor does So I guess that’s the real fix. Not sure the rest of this patch was needed. (In reply to comment #5) > (In reply to comment #4) > > for WebKit2 that's what the forcing of platformCursor does > > So I guess that’s the real fix. Not sure the rest of this patch was needed. Right. I figured I'd do that part anyway since I don't like having potential leaks present in the code. In the future I think we can get rid of the Cursor singletons and cache the underlying platform cursors instead. Committed r90705: <http://trac.webkit.org/changeset/90705> |