Summary: | <text>, <tspan> dominant-baseline attribute is not respected | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ian, ml, zimmermann | ||||||
Priority: | P4 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Bug Depends on: | 10380 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2006-01-08 01:49:01 PST
*** Bug 6873 has been marked as a duplicate of this bug. *** See http://bugzilla.opendarwin.org/show_bug.cgi?id=6873 for a nice test case. I'm almost surprised WildFox hasn't fixed this one yet in all the rest of his Text work. *** Bug 14005 has been marked as a duplicate of this bug. *** I postponed the baseline stuff, until the engine handles all kind of per-chunk/per-char transformations well. The last things missing before I'll start with this is: a) textLength/lengthAdjust support for textPath b) proper incorporation of letter/word spacing in our "buildLayoutInformation" code (to be able to support spacing for textPath, which is all drawn seperated..) That's it - from the top of my head. Greetings, Niko Created attachment 17182 [details]
Layout test results
Created attachment 17183 [details]
Initial patch
This does not fix Hixies glyphment align bug - gonna reopen it - it has a different origin.
Comment on attachment 17183 [details]
Initial patch
Hum. We should chat about this over IRC. This seems like it could add a lot of recursive tree walks in these (rare) cases that dominant baseline (like "nochange") is used.
Comment on attachment 17183 [details]
Initial patch
This is fine. As we discussed it could be done as part of RenderStyle instead, and just cached there. I don't expect this will ever become a perf issue however.
Comment on attachment 17182 [details]
Layout test results
fine.
Landed in r27692. |