Bug 64229

Summary:

Remove array size from generated JSC binding tables

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Patrick R. Gansterer 2011-07-09 01:45:30 PDT

see patch

Comment 1 Patrick R. Gansterer 2011-07-09 01:56:24 PDT

Created attachment 100205 [details]
Patch

Comment 2 Brent Fulgham 2011-07-10 19:07:48 PDT

Comment on attachment 100205 [details]
Patch

Looks like the EWS is happy, so the change seems safe.  I like the idea of allowing the compiler to compute the size at build time, since it's a horrible mistake if we declare with one size, but end up generating more (or less) entries in the table.

Comment 3 WebKit Review Bot 2011-07-10 19:55:38 PDT

Comment on attachment 100205 [details]
Patch

Clearing flags on attachment: 100205

Committed r90709: <http://trac.webkit.org/changeset/90709>

Comment 4 WebKit Review Bot 2011-07-10 19:55:42 PDT

All reviewed patches have been landed.  Closing bug.