Bug 64229

Summary: Remove array size from generated JSC binding tables
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-07-09 01:45:30 PDT
see patch
Attachments
Patch (8.59 KB, patch)
2011-07-09 01:56 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-09 01:56:24 PDT
Created attachment 100205 [details] Patch
Brent Fulgham
Comment 2 2011-07-10 19:07:48 PDT
Comment on attachment 100205 [details] Patch Looks like the EWS is happy, so the change seems safe. I like the idea of allowing the compiler to compute the size at build time, since it's a horrible mistake if we declare with one size, but end up generating more (or less) entries in the table.
WebKit Review Bot
Comment 3 2011-07-10 19:55:38 PDT
Comment on attachment 100205 [details] Patch Clearing flags on attachment: 100205 Committed r90709: <http://trac.webkit.org/changeset/90709>
WebKit Review Bot
Comment 4 2011-07-10 19:55:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.