Bug 64221

Summary: update the boilerplate documentation in the test_expectations.txt files
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Description Dirk Pranke 2011-07-08 17:43:47 PDT
update the boilerplate documentation in the test_expectations.txt files
Comment 1 Dirk Pranke 2011-07-08 17:46:00 PDT
Created attachment 100191 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-09 03:41:14 PDT
Comment on attachment 100191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100191&action=review

> LayoutTests/platform/mac/test_expectations.txt:1
> +// These are the layout test expectations for the Apple Macintosh port of WebKit.

I don't think "macintosh" exists anymore. :)  Just "Mac".  Also it's "Apple's" Mac port, since Chromium owns a differnet Mac port, as does Qt.
Comment 3 Dirk Pranke 2011-07-09 10:19:31 PDT
Comment on attachment 100191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100191&action=review

>> LayoutTests/platform/mac/test_expectations.txt:1
>> +// These are the layout test expectations for the Apple Macintosh port of WebKit.
> 
> I don't think "macintosh" exists anymore. :)  Just "Mac".  Also it's "Apple's" Mac port, since Chromium owns a differnet Mac port, as does Qt.

Really? Heh.

Anyway, good point about "Apple's" vs. "Apple". It felt weird to me (even weirder in the "Apple Win port", below), but I don't know why I didn't think to use the possessive.
Comment 4 Dirk Pranke 2011-07-11 16:33:42 PDT
Committed r90792: <http://trac.webkit.org/changeset/90792>