Summary: | AudioDevice::Stop can close NULL handle. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Berend-Jan Wever <skylined> | ||||||||
Component: | DOM | Assignee: | Chris Rogers <crogers> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | kbr | ||||||||
Priority: | P1 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows Vista | ||||||||||
Attachments: |
|
Description
Berend-Jan Wever
2011-07-08 03:35:10 PDT
Created attachment 100382 [details]
Patch
Comment on attachment 100382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100382&action=review Basically looks good except for a small issue in the bindings. > Source/WebCore/bindings/js/JSAudioContextCustom.cpp:72 > + return throwVMError(exec, createReferenceError(exec, "audio resources unavailable for AudioContext construction")); The JS bindings are throwing a ReferenceError, while the V8 bindings are throwing a SyntaxError. These should be aligned. Created attachment 100565 [details]
Patch
Sorry, this was already R+, but after some extensive testing I found that it's necessary to decrement s_hardwareContextCount in the uninitialize() method instead of destructor since garbage collection can take a long time and hold up new contexts being created. Comment on attachment 100565 [details]
Patch
OK.
Committed r90853: <http://trac.webkit.org/changeset/90853> |