Bug 64124

Summary:

REGRESSION(r90581): Broke a bunch of inspector tests (Requested by ojan on #webkit).

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

New Bugs

Assignee:

WebKit Commit Bot <commit-queue>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

caseq, ojan, pfeldman, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64080

Attachments:

Description	Flags
ROLLOUT of r90581	none

Description WebKit Commit Bot 2011-07-07 13:30:01 PDT

http://trac.webkit.org/changeset/90581 broke the build:
Broke a bunch of inspector tests (Requested by ojan on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

Comment 1 WebKit Commit Bot 2011-07-07 13:30:14 PDT

Created attachment 100025 [details]
ROLLOUT of r90581

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Ojan Vafai 2011-07-07 13:32:43 PDT

Tried to find you on IRC before rolling out...

This broke ~20 layout tests on the chromium win/linux canaries:
http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html,http/tests/inspector-enabled/console-log-before-frame-navigation.html,http/tests/inspector-enabled/database-open.html,http/tests/inspector-enabled/dom-storage-open.html,http/tests/inspector/change-iframe-src.html,http/tests/inspector/console-resource-errors.html,http/tests/inspector/console-websocket-error.html,http/tests/inspector/console-xhr-logging.html,http/tests/inspector/inspect-iframe-from-different-domain.html,http/tests/inspector/network-preflight-options.html,http/tests/inspector/network/download.html,http/tests/inspector/network/network-cachedresources-with-same-urls.html,http/tests/inspector/network/network-clear-after-disabled.html,http/tests/inspector/network/network-close-load-open.html,http/tests/inspector/network/network-content-replacement-xhr.html,http/tests/inspector/network/network-iframe-load-and-delete.html,http/tests/inspector/network/network-open-load-reopen.html,http/tests/inspector/resource-har-conversion.html,http/tests/inspector/resource-har-headers.html,http/tests/inspector/resource-parameters.html

And I believe it may have broke some inspector tests on non-chromium ports.

I believe this also broke the following chromium gtests on the Linux Tests bot:
TestContentScriptIsPresent
TestNetworkRawHeadersText
TestNetworkSize
TestNetworkSyncSize
TestNetworkTiming
TestNoScriptDuplicatesOnPanelSwitch
TestPageWithNoJavaScript
TestScriptsTabIsPopulatedOnInspectedPageRefresh
TestShowScriptsTab

For example, see http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/11784/steps/interactive_ui_tests/logs/TestContentScriptIsPresent

Comment 3 WebKit Review Bot 2011-07-07 13:45:23 PDT

Comment on attachment 100025 [details]
ROLLOUT of r90581

Clearing flags on attachment: 100025

Committed r90588: <http://trac.webkit.org/changeset/90588>

Comment 4 WebKit Review Bot 2011-07-07 13:45:28 PDT

All reviewed patches have been landed.  Closing bug.