Bug 64124

Summary: REGRESSION(r90581): Broke a bunch of inspector tests (Requested by ojan on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Severity: Normal CC: caseq, ojan, pfeldman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64080    
Description Flags
ROLLOUT of r90581 none

Description WebKit Commit Bot 2011-07-07 13:30:01 PDT
http://trac.webkit.org/changeset/90581 broke the build:
Broke a bunch of inspector tests (Requested by ojan on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Commit Bot 2011-07-07 13:30:14 PDT
Created attachment 100025 [details]
ROLLOUT of r90581

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ojan Vafai 2011-07-07 13:32:43 PDT
Tried to find you on IRC before rolling out...

This broke ~20 layout tests on the chromium win/linux canaries:

And I believe it may have broke some inspector tests on non-chromium ports.

I believe this also broke the following chromium gtests on the Linux Tests bot:

For example, see http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/11784/steps/interactive_ui_tests/logs/TestContentScriptIsPresent
Comment 3 WebKit Review Bot 2011-07-07 13:45:23 PDT
Comment on attachment 100025 [details]
ROLLOUT of r90581

Clearing flags on attachment: 100025

Committed r90588: <http://trac.webkit.org/changeset/90588>
Comment 4 WebKit Review Bot 2011-07-07 13:45:28 PDT
All reviewed patches have been landed.  Closing bug.