Bug 64088

Summary: Remove QtScript code from WebKit
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Minor CC: abarth, cmarcelo, hausmann, levin, ojan, webkit.review.bot
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch vestbo: review+

Jędrzej Nowacki
Reported 2011-07-07 07:55:23 PDT
Porting QtScript API over JSC C API will not be continued.
Attachments
Patch v1 (559.28 KB, patch)
2011-07-08 00:22 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
Patch (560.75 KB, patch)
2011-10-21 02:04 PDT, Simon Hausmann 		vestbo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2011-07-08 00:22:02 PDT
Created attachment 100084 [details] Patch v1 Proposed patch. The patch: - removes QtScript code from JavaScriptCore/qt, - obviously it touches some build files (I check Qt build, it works for me (TM) :-) ) - it deletes some checks for sanity bot
Andreas Kling
Comment 2 2011-07-08 07:10:42 PDT
Comment on attachment 100084 [details] Patch v1 Awww. Good bye, QtScript on top of JSC C API :'(
WebKit Review Bot
Comment 3 2011-07-08 08:29:33 PDT
Comment on attachment 100084 [details] Patch v1 Rejecting attachment 100084 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: alidatereviewer.py", line 56, in run changelog_entry = ChangeLog(changelog_path).latest_entry() File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 157, in latest_entry changelog_file = codecs.open(self.path, "r", "utf-8") File "/usr/lib/python2.6/codecs.py", line 881, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: u'/mnt/git/webkit-commit-queue/Source/JavaScriptCore/qt/ChangeLog' Full output: http://queues.webkit.org/results/8995771
Caio Marcelo de Oliveira Filho
Comment 4 2011-07-28 09:40:54 PDT
(In reply to comment #3) > IOError: [Errno 2] No such file or directory: u'/mnt/git/webkit-commit-queue/Source/JavaScriptCore/qt/ChangeLog' Because the patch remove this ChangeLog, maybe it needs a manual landing?
Simon Hausmann
Comment 5 2011-10-21 02:04:25 PDT
Created attachment 111925 [details] Patch
Simon Hausmann
Comment 6 2011-10-21 03:25:43 PDT
Committed r98093: <http://trac.webkit.org/changeset/98093>
Note You need to log in before you can comment on or make changes to this bug.