| Summary: | garden-o-matic shouldn't show flaky tests by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, eric, ojan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-07-06 00:28:28 PDT
Created attachment 99798 [details]
Patch
Comment on attachment 99798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99798&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:9 > +var kPassingResults = ['PASS']; Using an array here seems like overkill to me. I think a string would do. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:10 > +var kPassingResults = ['PASS']; > var kFailingResults = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT']; Should have mentioned in a previous review, you might want to alias these strings, e.g. var TIMEOUT = 'TIMEOUT'; It will save you pain down the road for when you typo 'TIMEOT'. With the variables, you'll get a nice JS exception right where the problem code is. var IMAGE+TEXT = 'IMAGE+TEXT'; :( Committed r90442: <http://trac.webkit.org/changeset/90442> IMAGE_TEXT it is! |