Bug 63973

Summary: Perl string concat failure on Leopard (causes NRWT to fail)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, dbates, dpranke, mitz, mrowe, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch dbates: review+, eric: commit-queue+

Description Eric Seidel (no email) 2011-07-05 20:58:06 PDT
Here is the NRWT output:

Running new-run-webkit-tests with one child process.
For more parallelism, run new-run-webkit-tests directly.
2011-07-05 20:47:17,904 64147 printing.py:470 INFO Using port 'mac-leopard'
2011-07-05 20:47:17,905 64147 printing.py:470 INFO Test configuration: <leopard, x86, debug, cpu>
2011-07-05 20:47:17,905 64147 printing.py:470 INFO Placing test results in /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/layout-test-results
2011-07-05 20:47:17,905 64147 printing.py:470 INFO Using Debug build
2011-07-05 20:47:17,905 64147 printing.py:470 INFO Pixel tests disabled
2011-07-05 20:47:17,905 64147 printing.py:470 INFO Regular timeout: 35000, slow test timeout: 175000
2011-07-05 20:47:18,022 64147 executive.py:432 DEBUG "perl Tools/Scripts/webkit-build-directory --configuration --debug" took 0.12s
2011-07-05 20:47:18,023 64147 printing.py:470 INFO Command line: Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/WebKitBuild/Debug/DumpRenderTree -
2011-07-05 20:47:18,023 64147 printing.py:470 INFO Worker model: inline
2011-07-05 20:47:18,023 64147 printing.py:470 INFO 
2011-07-05 20:47:18,023 64147 printing.py:470 INFO Collecting tests ...
2011-07-05 20:47:24,870 64147 test_files.py:96 DEBUG Test gathering took 6.845883 seconds
2011-07-05 20:47:24,870 64147 printing.py:470 INFO Parsing expectations ...
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.'
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `nm Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.'
2011-07-05 20:47:26,375 64147 test_expectations.py:334 ERROR FAILURES FOR <leopard, x86, debug, cpu>
2011-07-05 20:47:26,375 64147 test_expectations.py:339 ERROR Line:331 Path does not exist. http/tests/media/video-seekable-stall.html
2011-07-05 20:47:26,520 64147 printing.py:470 INFO Checking build ...
2011-07-05 20:47:33,851 64147 executive.py:432 DEBUG "Tools/Scripts/build-dumprendertree --debug" took 7.33s
2011-07-05 20:47:33,852 64147 webkit.py:108 ERROR DumpRenderTree was not found at Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/WebKitBuild/Debug/DumpRenderTree
2011-07-05 20:47:33,852 64147 run_webkit_tests.py:115 ERROR Build check failed
Ignoring unsupported option: --use-remote-links-to-tests
program finished with exit code 255
elapsedTime=18.751769

Note that ORWT sees the same failure, it's just not fatal:

perl ./Tools/Scripts/run-webkit-tests --no-launch-safari --no-new-test-results --no-sample-on-timeout --results-directory layout-test-results --use-remote-links-to-tests --debug --exit-after-n-crashes-or-timeouts 20 --exit-after-n-failures 500
 in dir /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['perl', './Tools/Scripts/run-webkit-tests', '--no-launch-safari', '--no-new-test-results', '--no-sample-on-timeout', '--results-directory', 'layout-test-results', '--use-remote-links-to-tests', '--debug', '--exit-after-n-crashes-or-timeouts', '20', '--exit-after-n-failures', '500']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-ZyAZVa/Render
  DISPLAY=/tmp/launch-636Faa/:0
  HOME=/Users/buildbot
  LOGNAME=buildbot
  PATH=/usr/bin:/bin:/usr/sbin:/sbin
  PWD=/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build
  SHELL=/bin/bash
  SSH_AUTH_SOCK=/tmp/launch-su48gv/Listeners
  TMPDIR=/var/folders/7j/7jO0FdJuGGazn740LjXU0++++TI/-Tmp-/
  USER=buildbot
 closing stdin
 using PTY: False
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
Running build-dumprendertree
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 145.
Use of uninitialized value in concatenation (.) or string at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.
Use of uninitialized value in string lt at /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/Tools/Scripts/webkitdirs.pm line 146.

It looks to be related to xcode version detection:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm#L145

I'm going to turn off NRWT for leopard for now.
Comment 1 Eric Seidel (no email) 2011-07-05 21:01:35 PDT
It's possible the exit in NRWT is due to the missing file from the Skipped list instead.  NRWT is rather picky about test_expectations matching reality.  Without a leopard box it's hard to tell.  In either case, this perl error should be fixed. :)
Comment 2 Eric Seidel (no email) 2011-07-05 22:57:12 PDT
It would be useful if someone with access to a Leopard machine could paste the output of "xcodebuild -version".  I suspect the regexp on http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm#L144 is failing.
Comment 3 Daniel Bates 2011-07-05 23:17:31 PDT
(In reply to comment #2)
> It would be useful if someone with access to a Leopard machine could paste the output of "xcodebuild -version".  I suspect the regexp on http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm#L144 is failing.

On my PowerBook G4 running 10.5.8:

[dbates-pbg4:~] dbates% xcodebuild -version
Component versions: DevToolsCore-921.0; DevToolsSupport-893.0
Comment 4 Daniel Bates 2011-07-05 23:22:56 PDT
(In reply to comment #3)
> [dbates-pbg4:~] dbates% xcodebuild -version
> Component versions: DevToolsCore-921.0; DevToolsSupport-893.0

For completeness these versions correspond to Xcode 3.0 whose About Xcode dialog lists the following version information:
[[ 
Component versions
Xcode IDE: 921.0
Xcode Core: 921.0
ToolSupport: 893.0
]]
Comment 5 Eric Seidel (no email) 2011-07-05 23:50:26 PDT
This was added by mitz in http://trac.webkit.org/changeset/84876.  There is unfortunately no bug to reference.
Comment 6 Eric Seidel (no email) 2011-07-05 23:51:17 PDT
Created attachment 99795 [details]
Patch
Comment 7 Daniel Bates 2011-07-05 23:52:17 PDT
Comment on attachment 99795 [details]
Patch

I was writing up such a patch with a comment to explain this. You beat me. :-P
Comment 8 Eric Seidel (no email) 2011-07-05 23:55:19 PDT
Committed r90439: <http://trac.webkit.org/changeset/90439>