Summary: | DFG JIT does not support method_check | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2011-07-05 20:55:14 PDT
Created attachment 99786 [details]
the patch
Attachment 99786 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:857: Declaration has space between type name and * in Instruction *getInstruction [whitespace/declaration] [3]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 99788 [details]
the patch (fix style)
Comment on attachment 99788 [details] the patch (fix style) Rejecting attachment 99788 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: rce/JavaScriptCore/dfg/DFGOperations.cpp patching file Source/JavaScriptCore/dfg/DFGOperations.h patching file Source/JavaScriptCore/dfg/DFGRepatch.cpp patching file Source/JavaScriptCore/dfg/DFGRepatch.h patching file Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp Hunk #1 succeeded at 1019 (offset 5 lines). patching file Source/JavaScriptCore/jit/JITWriteBarrier.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'..." exit_code: 1 Full output: http://queues.webkit.org/results/8985884 Created attachment 99907 [details]
the patch
Comment on attachment 99907 [details] the patch Clearing flags on attachment: 99907 Committed r90529: <http://trac.webkit.org/changeset/90529> All reviewed patches have been landed. Closing bug. |