Bug 63972

Summary: DFG JIT does not support method_check
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch (fix style)
barraclough: review+, webkit.review.bot: commit-queue-
the patch none

Description Filip Pizlo 2011-07-05 20:55:14 PDT
JSC bytecode contains a method_check opcode that is used to optimize method calls of the form o.foo(...).  The DFG JIT currently does not support this opcode at all, so JS functions that contain method calls cannot be compiled with DFG.  The DFG JIT should support both the method_check opcode and the optimizations associated with it.
Comment 1 Filip Pizlo 2011-07-05 21:02:33 PDT
Created attachment 99786 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-05 21:14:08 PDT
Attachment 99786 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:857:  Declaration has space between type name and * in Instruction *getInstruction  [whitespace/declaration] [3]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-07-05 21:17:46 PDT
Created attachment 99788 [details]
the patch (fix style)
Comment 4 WebKit Review Bot 2011-07-06 16:15:52 PDT
Comment on attachment 99788 [details]
the patch (fix style)

Rejecting attachment 99788 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
rce/JavaScriptCore/dfg/DFGOperations.cpp
patching file Source/JavaScriptCore/dfg/DFGOperations.h
patching file Source/JavaScriptCore/dfg/DFGRepatch.cpp
patching file Source/JavaScriptCore/dfg/DFGRepatch.h
patching file Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
Hunk #1 succeeded at 1019 (offset 5 lines).
patching file Source/JavaScriptCore/jit/JITWriteBarrier.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'..." exit_code: 1

Full output: http://queues.webkit.org/results/8985884
Comment 5 Filip Pizlo 2011-07-06 17:54:14 PDT
Created attachment 99907 [details]
the patch
Comment 6 WebKit Review Bot 2011-07-06 20:42:15 PDT
Comment on attachment 99907 [details]
the patch

Clearing flags on attachment: 99907

Committed r90529: <http://trac.webkit.org/changeset/90529>
Comment 7 WebKit Review Bot 2011-07-06 20:42:19 PDT
All reviewed patches have been landed.  Closing bug.