Bug 63969

Summary: Add first unit tests for garden-o-matic
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2011-07-05 20:02:50 PDT
Add first unit tests for garden-o-matic
Attachments
Patch (4.98 KB, patch)
2011-07-05 20:03 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-05 20:03:37 PDT
Created attachment 99783 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-05 20:06:02 PDT
Comment on attachment 99783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99783&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:2 > +<!DOCTYPE html> > +<html> Why not just run these as part of the layout tests? How are these goign to be run on the bots?
Adam Barth
Comment 3 2011-07-05 20:11:08 PDT
> Why not just run these as part of the layout tests? Are you saying that the code for garden-o-matic should be in the LayoutTest directory or that the LayoutTest directory should include scripts that reside in the Tools directory? Niether of those options is appealing. For the first one, garden-o-matic is a Tool, not a LayoutTests, so it should be in Tools directory. For the second one, we don't have any dependencies back from LayoutTests to Tools, and adding one would break at the downstream Chromium configuration and probably the downstream Apple configuration as well. > How are these goign to be run on the bots? Currently, they're not going to run on the bots. That sounds like a problem we should solve in the future if/when we have a problem keeping these tests green.
Eric Seidel (no email)
Comment 4 2011-07-05 20:13:00 PDT
Comment on attachment 99783 [details] Patch Tests which aren't run on the bots turn red. We've learned that lesson several times now. :)
Adam Barth
Comment 5 2011-07-05 20:15:29 PDT
Committed r90430: <http://trac.webkit.org/changeset/90430>
Tony Chang
Comment 6 2011-07-06 10:22:30 PDT
FYI, the layout test results HTML file generated by NRWT are tested as part of the LayoutTests (in fast/harness/results.html). The test doesn't depend on Tools, but Tools does depend on it (NRWT copies results.html to the test output directory).
Note You need to log in before you can comment on or make changes to this bug.