Bug 63968

Summary: Add comment to explain Vector usage in FontCache::purgeInactiveFontData
Product: WebKit Reporter: Yuzo Fujishima <yuzo>
Component: Page LoadingAssignee: Yuzo Fujishima <yuzo>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, perrymasterson1, thomasclein7, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yuzo Fujishima
Reported 2011-07-05 19:21:36 PDT
Vector<const SimpleFontData*, 20> fontDataToDelete is used to temporarily record which font data to delete but it is actually unnecessary.
Attachments
Patch (2.15 KB, patch)
2011-07-05 19:25 PDT, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-07-05 20:26 PDT, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1 2011-07-05 19:25:36 PDT
Created attachment 99782 [details] Patch
mitz
Comment 2 2011-07-05 19:30:49 PDT
Comment on attachment 99782 [details] Patch Has anything changed since <http://trac.webkit.org/changeset/44011> that would make this safe?
Yuzo Fujishima
Comment 3 2011-07-05 20:26:33 PDT
Created attachment 99784 [details] Patch
Yuzo Fujishima
Comment 4 2011-07-05 20:28:07 PDT
Thank you for the review and sorry for the oversight. I believe it is worth a comment. Hence a new patch to add one.
WebKit Review Bot
Comment 5 2011-07-10 18:38:25 PDT
Comment on attachment 99784 [details] Patch Clearing flags on attachment: 99784 Committed r90700: <http://trac.webkit.org/changeset/90700>
WebKit Review Bot
Comment 6 2011-07-10 18:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.