Bug 63967

Summary: Import qunit JavaScript unit testing framework
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2011-07-05 19:12:04 PDT
Import qunit JavaScript unit testing framework
Comment 1 Adam Barth 2011-07-05 19:12:59 PDT
Created attachment 99780 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-05 19:17:25 PDT
Attachment 99780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ChangeLog', u'Source/Thi..." exit_code: 1

Last 3072 characters of output:
ter.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:269:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:270:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:271:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:279:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:282:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:289:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:290:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:291:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:292:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:293:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:294:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:295:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:296:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:300:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:301:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:302:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:303:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:304:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:305:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:306:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:307:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:308:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:309:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:310:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:311:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:312:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:313:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:317:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:318:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:319:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:322:  Line contains tab character.  [whitespace/tab] [5]
Source/ThirdParty/qunit/test/test.js:323:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1431 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2011-07-05 19:29:11 PDT
Comment on attachment 99780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99780&action=review

OK.

> Source/ThirdParty/qunit/qunit/qunit.css:7
> + * Dual licensed under the MIT (MIT-LICENSE.txt)

MIT is OK?
Comment 4 Adam Barth 2011-07-05 19:29:45 PDT
> MIT is OK?

Yes.  :)
Comment 5 Adam Barth 2011-07-05 19:30:55 PDT
Committed r90427: <http://trac.webkit.org/changeset/90427>