Summary: | [WK2] IconDatabase: Add a way to notify when icon data is available | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, beidson, mario, svillar, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 96476 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-07-05 10:04:33 PDT
A possible solution would be to add a client callback to notify when the icon data is available (and imageForPageURL() will return a valid image) called from both didImportIconDataForPageURL() and setIconDataForIconURL() Created attachment 163129 [details]
Patch proposal
Attaching a patch proposal for this issue.
The current patch is what I'm using now in a local branch to implement the favicons API for WebKit2GTK+, and has been apparently working fine (at least as good as I would expect) for the last week.
Attachment 163129 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:44: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:44: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 1 in 8 files Oops! Sorry about this. I will fix it in a follow-up patch, but first I'd say it would be better to concentrate on reviewing the actual code :-) Created attachment 163598 [details]
Patch proposal
Uploading a new patch here fixing the code style issue.
Ping reviewers? Committed r129742: <http://trac.webkit.org/changeset/129742> Committed r129789: <http://trac.webkit.org/changeset/129789> |