Bug 63924

Summary:

[Qt] "cat" is not available when building

Product:

WebKit

Reporter:

Alexandru Chiculita <achicu>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

menard, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix the changelog.	none
Fix the retardness of Windows platform.	none

Alexandru Chiculita

Reported 2011-07-05 01:11:27 PDT

The following bug broke the QT Win build: https://bugs.webkit.org/show_bug.cgi?id=62114 -cssprops.commands = perl -ne \"print lc\" ${QMAKE_FILE_NAME} $${DASHBOARDSUPPORTCSSPROPERTIES} $${EXTRACSSPROPERTIES} > $${WC_GENERATED_SOURCES_DIR}/${QMAKE_FILE_BASE}.in && cd $$WC_GENERATED_SOURCES_DIR && perl $$cssprops.wkScript && $(DEL_FILE) ${QMAKE_FILE_BASE}.in ${QMAKE_FILE_BASE}.gperf +cssprops.commands = cat ${QMAKE_FILE_NAME} $${DASHBOARDSUPPORTCSSPROPERTIES} $${EXTRACSSPROPERTIES} > $${WC_GENERATED_SOURCES_DIR}/${QMAKE_FILE_BASE}.in && cd $$WC_GENERATED_SOURCES_DIR && perl -I$$PWD/bindings/scripts $$cssprops.wkScript --defines \"$${FEATURE_DEFINES_JAVASCRIPT}\" --preprocessor \"$${QMAKE_MOC} -E\" ${QMAKE_FILE_NAME} && $(DEL_FILE) ${QMAKE_FILE_BASE}.in ${QMAKE_FILE_BASE}.gperf broke the Qt port on Windows with Visual Studio. "cat" doesn't exist on Windows. Unfortunately the Qt Windows bots are built with Cygwin so cat exists.

Attachments
Patch (3.14 KB, patch) 2011-07-05 01:30 PDT, Alexandru Chiculita	no flags	Details Formatted Diff Diff
Fix the changelog. (3.17 KB, patch) 2011-07-05 04:35 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Fix the retardness of Windows platform. (3.17 KB, patch) 2011-07-05 04:37 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexandru Chiculita

Comment 1 2011-07-05 01:30:17 PDT

Created attachment 99679 [details] Patch

Alexis Menard (darktears)

Comment 2 2011-07-05 04:35:18 PDT

Created attachment 99699 [details] Fix the changelog.

Alexis Menard (darktears)

Comment 3 2011-07-05 04:37:16 PDT

Created attachment 99700 [details] Fix the retardness of Windows platform.

Simon Hausmann

Comment 4 2011-07-05 04:58:46 PDT

Comment on attachment 99700 [details] Fix the retardness of Windows platform. rs=me

WebKit Review Bot

Comment 5 2011-07-05 05:49:32 PDT

Comment on attachment 99700 [details] Fix the retardness of Windows platform. Clearing flags on attachment: 99700 Committed r90392: <http://trac.webkit.org/changeset/90392>

WebKit Review Bot

Comment 6 2011-07-05 05:49:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.