Bug 63924

Summary: [Qt] "cat" is not available when building
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: menard, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix the changelog.
none
Fix the retardness of Windows platform. none

Description Alexandru Chiculita 2011-07-05 01:11:27 PDT
The following bug broke the QT Win build:
https://bugs.webkit.org/show_bug.cgi?id=62114

-cssprops.commands = perl -ne \"print lc\" ${QMAKE_FILE_NAME} $${DASHBOARDSUPPORTCSSPROPERTIES} $${EXTRACSSPROPERTIES} > $${WC_GENERATED_SOURCES_DIR}/${QMAKE_FILE_BASE}.in && cd $$WC_GENERATED_SOURCES_DIR && perl $$cssprops.wkScript && $(DEL_FILE) ${QMAKE_FILE_BASE}.in ${QMAKE_FILE_BASE}.gperf
+cssprops.commands = cat ${QMAKE_FILE_NAME} $${DASHBOARDSUPPORTCSSPROPERTIES} $${EXTRACSSPROPERTIES} > $${WC_GENERATED_SOURCES_DIR}/${QMAKE_FILE_BASE}.in && cd $$WC_GENERATED_SOURCES_DIR && perl -I$$PWD/bindings/scripts $$cssprops.wkScript --defines \"$${FEATURE_DEFINES_JAVASCRIPT}\" --preprocessor \"$${QMAKE_MOC} -E\" ${QMAKE_FILE_NAME} && $(DEL_FILE) ${QMAKE_FILE_BASE}.in ${QMAKE_FILE_BASE}.gperf

broke the Qt port on Windows with Visual Studio. "cat" doesn't exist on Windows.

Unfortunately the Qt Windows bots are built with Cygwin so cat exists.
Comment 1 Alexandru Chiculita 2011-07-05 01:30:17 PDT
Created attachment 99679 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-07-05 04:35:18 PDT
Created attachment 99699 [details]
Fix the changelog.
Comment 3 Alexis Menard (darktears) 2011-07-05 04:37:16 PDT
Created attachment 99700 [details]
Fix the retardness of Windows platform.
Comment 4 Simon Hausmann 2011-07-05 04:58:46 PDT
Comment on attachment 99700 [details]
Fix the retardness of Windows platform.

rs=me
Comment 5 WebKit Review Bot 2011-07-05 05:49:32 PDT
Comment on attachment 99700 [details]
Fix the retardness of Windows platform.

Clearing flags on attachment: 99700

Committed r90392: <http://trac.webkit.org/changeset/90392>
Comment 6 WebKit Review Bot 2011-07-05 05:49:37 PDT
All reviewed patches have been landed.  Closing bug.