Bug 63879

Summary:

Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

63881

Attachments:

Description	Flags
Preliminare patch	none
The patch	sam: review+

Gavin Barraclough

Reported 2011-07-03 15:33:31 PDT

There is a lot of copy & paste code here; we can reduce duplication by making a shared implementation.

Attachments
Preliminare patch (45.86 KB, patch) 2011-07-03 15:34 PDT, Gavin Barraclough	no flags	Details Formatted Diff Diff
The patch (47.98 KB, patch) 2011-07-03 16:35 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2011-07-03 15:34:10 PDT

Created attachment 99584 [details] Preliminare patch

Gavin Barraclough

Comment 2 2011-07-03 16:35:21 PDT

Created attachment 99585 [details] The patch SunSpider shows a small progression, likely just noise, but this patch will optimize op_loop_if_lesseq!

WebKit Review Bot

Comment 3 2011-07-03 18:31:07 PDT

Attachment 99585 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JIT.h:723: The parameter name "condition" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JIT.h:723: emit_compareAndJump is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JIT.h:724: The parameter name "condition" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JIT.h:724: The parameter name "iter" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JIT.h:724: emit_compareAndJumpSlow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:87: JIT::emit_compareAndJump is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:138: JIT::emit_compareAndJumpSlow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITArithmetic.cpp:318: JIT::emit_compareAndJump is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITArithmetic.cpp:362: JIT::emit_compareAndJumpSlow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 9 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 4 2011-07-03 22:59:32 PDT

Fixed in r90352

Note You need to log in before you can comment on or make changes to this bug.