Summary: | Python tests are failing on leopard | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, aroben, dpranke, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/31976/steps/webkitpy-test/logs/stdio | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-07-01 13:43:57 PDT
We need to skip those tests when the multiprocess package isn't available. I'm not sure what the deal with with metered stream. Created attachment 99521 [details]
Patch
I was pretty sure we had to not call flush() at some point as a result of a bug, so I had removed it in bug 60326. I don't remember what the context was, unfortunately. I've added it back in, and tested under python 2.5 and 2.6 on my SL box. Hopefully this fixes things ... Comment on attachment 99521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99521&action=review Thank you for fixing. > Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:69 > + def flush(self): We might want to comment that this is only needed for Python 2.5 here. > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:54 > +SHOULD_TEST_PROCESSES = multiprocessing and sys.platform not in ('cygwin') I would have made this a member on MainTest. Then accessed it with self.should_test_processes (or even an function). Your welcome to ignore my nits of course. Comment on attachment 99521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99521&action=review >> Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:69 >> + def flush(self): > > We might want to comment that this is only needed for Python 2.5 here. Will do. >> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:54 >> +SHOULD_TEST_PROCESSES = multiprocessing and sys.platform not in ('cygwin') > > I would have made this a member on MainTest. Then accessed it with self.should_test_processes (or even an function). I preferred the file-level constant near the import, since that's where the other multiprocessing specific logic is. Committed r90422: <http://trac.webkit.org/changeset/90422> webkitpy test is failing on Chromium Windows and preventing the rest of tests to run ever since this patch was landed: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/16355 (In reply to comment #8) > webkitpy test is failing on Chromium Windows and preventing the rest of tests to run ever since this patch was landed: > http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/16355 Hm. That looks like test-webkitpy is perhaps trying to run some of the multiprocessing tests and failing. I'll patch that this afternoon. I've filed bug 64137 for the windows issues (and uploaded a patch). |