Summary: | HTMLMediaElement prematurely starts progress timer to check buffering status of audio source. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Abhinav Mithal <abhinav.mithal> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | aestes, eric.carlson, jer.noble, laszlo.gombos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | S60 Hardware | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Abhinav Mithal
2011-07-01 11:34:09 PDT
Created attachment 99500 [details]
This fixes the timer to be fired after media resource is loaded.
Attachment 99500 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 99502 [details]
This fixes the timer to be fired after media resource is loaded.
Change Log updated with Bug ID.
The spec doesn't seem to require that the "stalled" and "progress" events require readyState() to be at HAVE_METADATA, only that the network state is at NETWORK_LOADING. Can you clarify where in the spec you think this requirement lies? (In reply to comment #4) > The spec doesn't seem to require that the "stalled" and "progress" events require readyState() to be at HAVE_METADATA, only that the network state is at NETWORK_LOADING. Can you clarify where in the spec you think this requirement lies? I agree. Data must be loaded to reach HAVE_METADATA, and spec clearly says that progress events must be fired while media data is loaded: > Every 350ms (±200ms) or for every byte received, whichever is least > frequent, queue a task to fire a simple event named progress at > the element. and that a stalled event is to be fired when data loading stalls: > The stall timeout is a user-agent defined length of time, which > should be about three seconds. When a media element that is > actively attempting to obtain media data has failed to receive > any data for a duration equal to the stall timeout, the user > agent must queue a task to fire a simple event named stalled > at the element. http://www.w3.org/TR/html5/the-iframe-element.html#concept-media-load-resource The Qt port has been removed from WebKit, resolving this bug. |