Bug 63801 – [Chromium] HTML5 Canvas context.createPattern(image, repetition) can throw TYPE_MISMATCH_ERR exception.

• Component: Canvas
• Status: RESOLVED INVALID

[Dongseong Hwang]

Chromium failed this test : http://dev.w3.org/html5/2dcontext/#dom-context-2d-createpattern

[Dongseong Hwang]

Created attachment 99465 [details]
patch

JavaScriptCore treats this by JSCanvasRenderingContext2DCustom.cpp but V8 does not treats this.

From HTML5 canvas spec:
http://dev.w3.org/html5/2dcontext/#dom-context-2d-createpattern

"If the first argument isn't an img, canvas, or video element, throws a TYPE_MISMATCH_ERR exception."

This patch makes Chromium pass canvas/philip/tests/2d.pattern.image.undefined.html

[WebKit Review Bot]

Attachment 99465 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:150:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dongseong Hwang]

Created attachment 99569 [details]
patch

[Dongseong Hwang]

Created attachment 99672 [details]
patch

[WebKit Review Bot]

Comment on attachment 99672 [details]
patch

Attachment 99672 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8982679

New failing tests:
canvas/philip/tests/2d.path.arc.nonempty.html

[WebKit Review Bot]

Created attachment 99674 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dongseong Hwang]

Created attachment 99678 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 99678 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99678&action=review

> Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:106
> +    fail:

Really?  We use goto in the v8 bindings?

[Andreas Kling]

I'm not sure this is correct.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-createpattern no longer has the part about TYPE_MISMATCH_ERR. IIRC, Web IDL specifies that this shouldn't match any of the overloads, but instead raise TypeError. ( http://www.w3.org/TR/WebIDL/#es-operations )

[Dongseong Hwang]

I copied it from the derived source.
I thought I should make at the lowest changes.
However, I agree. I should remove goto.

(In reply to comment #8)
> (From update of attachment 99678 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99678&action=review
> 
> > Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:106
> > +    fail:
> 
> Really?  We use goto in the v8 bindings?

[Dongseong Hwang]

(In reply to comment #9)
> I'm not sure this is correct.
> 
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-createpattern no longer has the part about TYPE_MISMATCH_ERR. IIRC, Web IDL specifies that this shouldn't match any of the overloads, but instead raise TypeError. ( http://www.w3.org/TR/WebIDL/#es-operations )

I'm not familiar with w3 spec, but above spec is Last Updated 1 July 2011. The spec I had attached is W3C Working Draft 24 May 2011.
Which is correct?

[Ojan Vafai]

(In reply to comment #11)
> (In reply to comment #9)
> > I'm not sure this is correct.
> > 
> > http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-createpattern no longer has the part about TYPE_MISMATCH_ERR. IIRC, Web IDL specifies that this shouldn't match any of the overloads, but instead raise TypeError. ( http://www.w3.org/TR/WebIDL/#es-operations )
> 
> I'm not familiar with w3 spec, but above spec is Last Updated 1 July 2011. The spec I had attached is W3C Working Draft 24 May 2011.
> Which is correct?

For WebKit, we use the whatwg.org copy of the spec as the one that we implement. Although, in this specific case, it looks like both specs have changed to no longer throw an error in this case.

[Ojan Vafai]

Comment on attachment 99678 [details]
patch

Please reopen the bug if you believe I've misread the spec.