Bug 63765

Summary: Remove positionForCoordinates
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-06-30 16:01:53 PDT
We have no need for a positionForCoordinates method when we have positionForPoint.
Attachments
Patch (8.63 KB, patch)
2011-06-30 16:08 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-30 16:08:42 PDT
Created attachment 99388 [details] Patch
Emil A Eklund
Comment 2 2011-06-30 16:10:34 PDT
Yay!
Eric Seidel (no email)
Comment 3 2011-06-30 16:45:04 PDT
Comment on attachment 99388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99388&action=review LGTM. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1160 > + // FIXME: Why would a renderer exist when the Document isn't attached to a frame? I know frames stay alive for a brief moment while iframes are detached. Unclear if that could be related here.
Levi Weintraub
Comment 4 2011-06-30 16:48:26 PDT
Comment on attachment 99388 [details] Patch Clearing flags on attachment: 99388 Committed r90186: <http://trac.webkit.org/changeset/90186>
Levi Weintraub
Comment 5 2011-06-30 16:48:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.