Bug 63672

Summary: Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, eric, leviw, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 52099    
Attachments:
Description Flags
cleanup none

Ryosuke Niwa
Reported 2011-06-29 17:12:25 PDT
Right now, isNodeInTextFormControl takes Node* but this results in various editing code calling this function with deprecatedNode. Also, there are many places where we'd like to obtain the enclosing text form control. We can cleanup these code by introducing enclosingTextFormControl(const Position&) that replaces isNodeInTextFormControl(Node*).
Attachments
cleanup (12.27 KB, patch)
2011-06-29 18:55 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-06-29 18:55:49 PDT
Created attachment 99207 [details] cleanup
Kent Tamura
Comment 2 2011-06-30 01:58:20 PDT
Comment on attachment 99207 [details] cleanup Looks good cleanup.
WebKit Review Bot
Comment 3 2011-06-30 02:14:30 PDT
Comment on attachment 99207 [details] cleanup Clearing flags on attachment: 99207 Committed r90098: <http://trac.webkit.org/changeset/90098>
WebKit Review Bot
Comment 4 2011-06-30 02:14:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.