Summary: | X86Assembler does not encode byte registers in 64-bit mode correctly. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2011-06-29 15:46:14 PDT
Created attachment 99169 [details]
the patch
Attachment 99169 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:2005: Missing space inside { }. [whitespace/braces] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 99178 [details]
the patch (fix style)
Comment on attachment 99178 [details]
the patch (fix style)
r-ing per our discussion.
Created attachment 99246 [details]
the patch (redid as per review)
Comment on attachment 99246 [details] the patch (redid as per review) Clearing flags on attachment: 99246 Committed r90157: <http://trac.webkit.org/changeset/90157> All reviewed patches have been landed. Closing bug. |