Bug 63663 – Switch nodeAtPoint to to new layout types

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Emil A Eklund]

Convert nodeAtPoint to new layout abstraction.

[Emil A Eklund]

Created attachment 99166 [details]
Patch

[Emil A Eklund]

Created attachment 99360 [details]
Patch

[Emil A Eklund]

Updated patch to ToT.

[Eric Seidel (no email)]

Comment on attachment 99360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99360&action=review

> Source/WebCore/rendering/LayoutTypes.h:67
> +inline LayoutSize toLayoutSize(const LayoutPoint& p)
> +{
> +    return LayoutSize(p.x(), p.y());
> +}
> +
> +inline LayoutPoint toLayoutPoint(const LayoutSize& p)
> +{
> +    return LayoutPoint(p.width(), p.height());
> +}
> +
> +inline LayoutPoint roundedLayoutPoint(const FloatPoint& p)
> +{
> +    return roundedIntPoint(p);
> +}
> +
> +inline LayoutUnit roundedLayoutUnit(float value)
> +{
> +    return lroundf(value);
> +}

Same fear.  What will these do for float types?  I feel like we need to consider those when inventing these abstractions.

[Eric Seidel (no email)]

Comment on attachment 99360 [details]
Patch

OK.

[Emil A Eklund]

Created attachment 99874 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 99874 [details]
Patch for landing

Rejecting attachment 99874 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
tual bool WebCore::EllipsisBox::nodeAtPoint(const WebCore::HitTestRequest&, WebCore::HitTestResult&, const WebCore::LayoutPoint&, const WebCore::LayoutPoint&, int, int)':
Source/WebCore/rendering/EllipsisBox.cpp:121: error: 'toLayoutSize' was not declared in this scope
  CXX(target) out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/InlineBox.o
make: *** [out/Debug/obj.target/webcore_rendering/Source/WebCore/rendering/EllipsisBox.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/8985844

[Emil A Eklund]

Created attachment 99886 [details]
Patch for landing

Conflict resolution fail. Trying again.

[WebKit Review Bot]

Comment on attachment 99886 [details]
Patch for landing

Rejecting attachment 99886 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 90503 = 5ce0fa720511e9d2b91a6a308a274448790a32e1
r90504 = a5bd88a4e43cd8c089e2bc487b668060608f5dc8
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': timed out waiting for server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295

Died at Tools/Scripts/update-webkit line 146.

Full output: http://queues.webkit.org/results/8990706

[WebKit Review Bot]

Comment on attachment 99886 [details]
Patch for landing

Clearing flags on attachment: 99886

Committed r90515: <http://trac.webkit.org/changeset/90515>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.