Bug 63630

Summary: [Qt][WK2] Implement the rest of WTR::PlatformWebView
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Patch
none
Patch benjamin: commit-queue+

Balazs Kelemen
Reported 2011-06-29 07:55:19 PDT
Namely windowFrame and setWindowFrame. I don't know which tests using these and which ones can be fixed by implementing them. However it's not a big deal and we can unskip passing tests in the future.
Attachments
Patch (1.70 KB, patch)
2011-06-29 08:00 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2011-07-10 10:24 PDT, Benjamin Poulain 		benjamin: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-06-29 08:00:01 PDT
Created attachment 99090 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-06-29 09:16:02 PDT
Comment on attachment 99090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99090&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:100 > +void PlatformWebView::setWindowFrame(WKRect wkRect) why not jsut call that rect. This wk prefix doesnt serve anything
Balazs Kelemen
Comment 3 2011-06-30 00:37:29 PDT
(In reply to comment #2) > (From update of attachment 99090 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=99090&action=review > > > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:100 > > +void PlatformWebView::setWindowFrame(WKRect wkRect) > > why not jsut call that rect. This wk prefix doesnt serve anything Okeydokey.
Balazs Kelemen
Comment 4 2011-06-30 01:00:51 PDT
Committed r90095: <http://trac.webkit.org/changeset/90095>
Benjamin Poulain
Comment 5 2011-07-10 10:16:38 PDT
Reopening, this was reverted by accident.
Benjamin Poulain
Comment 6 2011-07-10 10:24:29 PDT
Created attachment 100230 [details] Patch
Benjamin Poulain
Comment 7 2011-07-10 10:25:04 PDT
Comment on attachment 100230 [details] Patch Updating was taking forever, let's use the commit bot :)
Benjamin Poulain
Comment 8 2011-07-10 11:05:33 PDT
Committed r90693: <http://trac.webkit.org/changeset/90693>
Note You need to log in before you can comment on or make changes to this bug.