Summary: | [Chromium] isRedirect is incorrectly determined for decidePolicyForNavigation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Smith <binji> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
I don't believe a LayoutTest is necessary for this patch, because isRedirect is only used in chromium (for determining whether to fork a process), and has no user-visible effect in the browser. Comment on attachment 99017 [details] Patch to fix this bug. All patch require a ChangeLog: http://www.webkit.org/coding/contributing.html Comment on attachment 99017 [details]
Patch to fix this bug.
Is this testable with a Chromium WebKit API test? Generally, these sorts of subtle changes are easy to regress if we don't have any test coverage. If this is used for forking processes in the embedder, perhaps we can write a test at that layer?
(Marking r- because of the lack of changelog.)
Yes, I believe it would be possible to test at that level. Is it WebKit/Source/WebKit/chromium/tests/*? Created attachment 105710 [details]
Patch
It's been a while since I've had time to work on this one... :) Adam, can you review my new patch? I've included a test in WebFrameTest that exhibits the bug (when the fix in FrameLoaderClientImpl.cpp is removed). Comment on attachment 105710 [details]
Patch
Looks great. Thanks for adding the ChangeLog and test.
Adam, is there something else I need to do to commit this patch? It seems that it is in an infinite commit-queue. :) Comment on attachment 105710 [details]
Patch
We just need to approve it for the queue!
Comment on attachment 105710 [details] Patch Clearing flags on attachment: 105710 Committed r94630: <http://trac.webkit.org/changeset/94630> All reviewed patches have been landed. Closing bug. |
Created attachment 99017 [details] Patch to fix this bug. In FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction() isRedirect is currently determined by hasRedirectChain(), which checks for an non-empty redirect chain. Instead, it should check for a redirect chain with more than one element. All valid redirects will have at least the source URL and the destination URL in the redirect chain.