| Summary: | Simplify AudioBufferSourceNode rendering | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||
| Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | kbr | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Rogers
2011-06-28 16:53:08 PDT
Created attachment 99003 [details]
Patch
Comment on attachment 99003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99003&action=review Thanks for walking me through the code offline. Few comments as we discussed. > Source/WebCore/webaudio/AudioBufferSourceNode.cpp:121 > + size_t bufferFramesToProcess = framesToProcess - quantumFrameOffset; Missing zeroing from the beginning of the quantum to the quantumFrameOffset. > Source/WebCore/webaudio/AudioBufferSourceNode.cpp:246 > + // Final sanity check on buffer access. Should there be a FIXME to try to get rid of this check, and use assertions and guards outside the loop instead? > Source/WebCore/webaudio/AudioBufferSourceNode.h:54 > + void renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames); This should be private. Created attachment 99140 [details]
Patch
Comment on attachment 99003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99003&action=review Also please note at line 250 of the new patch I've addressed the small clicks issue with the "pool" demo I discussed with you >> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:121 >> + size_t bufferFramesToProcess = framesToProcess - quantumFrameOffset; > > Missing zeroing from the beginning of the quantum to the quantumFrameOffset. FIXED: I've added the zeroing inside renderFromBuffer() >> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:246 >> + // Final sanity check on buffer access. > > Should there be a FIXME to try to get rid of this check, and use assertions and guards outside the loop instead? Added FIXME >> Source/WebCore/webaudio/AudioBufferSourceNode.h:54 >> + void renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames); > > This should be private. FIXED Comment on attachment 99140 [details]
Patch
Looks great.
Committed r90042: <http://trac.webkit.org/changeset/90042> |