Summary: | TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Rybin <peter.rybin> | ||||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap, peter.rybin, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Peter Rybin
2011-06-28 09:56:53 PDT
Created attachment 107705 [details]
Patch
I'm not absolutely happy with "BasedNumber" type name, but it was the simplest option. There are many places across the codebase that could use BasedNumber instead of int, but I'm not sure I can propagate the new type throughout entire WebKit here. Comment on attachment 107705 [details] Patch This change is great. Maybe instead of BasedNumber we should use the name OrdinalNumber? http://en.wikipedia.org/wiki/Ordinal_number That's a number used for ordering as opposed to a number use for counting, which is a cardinal number. Created attachment 107875 [details]
Patch
Comment on attachment 107875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107875&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This line will prevent the patch from being landed automatically. In this case, you should explain that there are no new tests because this patch is not changing behavior. Created attachment 107883 [details]
Patch
Comment on attachment 107883 [details] Patch Clearing flags on attachment: 107883 Committed r95449: <http://trac.webkit.org/changeset/95449> All reviewed patches have been landed. Closing bug. |