Bug 63537

Summary:

Skip cache validation on back with HTTPS.

Product:

WebKit

Reporter:

Adam Langley <agl>

Component:

WebCore Misc.

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, mjs, tony, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
Patch for landing	none
Patch for landing	none

Adam Langley

Reported 2011-06-28 07:52:06 PDT

For back navigations over HTTP, WebKit sets a flag to use cached data irrespective of whether it has expired. However, this isn't currently done for HTTPS. The logic in question was added in https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been precautionary. However, both Firefox and IE will use this back navigation trick for HTTPS as well and so we should probably behave likewise.

Attachments
patch (2.78 KB, patch) 2011-06-28 07:53 PDT, Adam Langley	no flags	Details Formatted Diff Diff
Patch for landing (1.90 KB, patch) 2011-06-28 16:48 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (10.64 KB, patch) 2011-06-28 17:38 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Langley

Comment 1 2011-06-28 07:53:12 PDT

Created attachment 98921 [details] patch

Tony Chang

Comment 2 2011-06-28 11:16:41 PDT

Can we write a layout test for this?

Adam Barth

Comment 3 2011-06-28 14:02:17 PDT

Comment on attachment 98921 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=98921&action=review > Source/WebCore/ChangeLog:17 > + https://bugs.webkit.org/show_bug.cgi?id=63537 This bug link needs to be the first one in the ChangeLog or else the tools will get confused. Usually we put it right under the bug title.

Adam Barth

Comment 4 2011-06-28 16:38:17 PDT

Comment on attachment 98921 [details] patch I'll take a crack at writing a test. Thanks agl.

Adam Barth

Comment 5 2011-06-28 16:48:00 PDT

I'm not sure if we have a good way to test this patch. The problem is that dumpResourceLoadCallbacks doesn't include the cache policy.

Adam Barth

Comment 6 2011-06-28 16:48:49 PDT

Created attachment 99000 [details] Patch for landing

Adam Barth

Comment 7 2011-06-28 16:49:15 PDT

If someone has an idea for a good way to test this patch, please feel free to re-open this bug and assign it to me.

Tony Chang

Comment 8 2011-06-28 17:01:30 PDT

LayoutTests/http/tests/cache/history-only-cached-subresource-loads.html seems to load a page in a new window with a random number. When pressing back, it checks to see if the random number has changed.

Adam Barth

Comment 9 2011-06-28 17:08:54 PDT

Great. Thanks.

Adam Barth

Comment 10 2011-06-28 17:38:36 PDT

Created attachment 99008 [details] Patch for landing

WebKit Review Bot

Comment 11 2011-06-28 18:04:08 PDT

Comment on attachment 99008 [details] Patch for landing Clearing flags on attachment: 99008 Committed r89982: <http://trac.webkit.org/changeset/89982>

WebKit Review Bot

Comment 12 2011-06-28 18:04:13 PDT

All reviewed patches have been landed. Closing bug.

David Kilzer (:ddkilzer)

Comment 13 2011-11-08 08:05:40 PST

<rdar://problem/10412387>

Note You need to log in before you can comment on or make changes to this bug.