| Summary: | [Chromium] DRT: Add setHixie76WebSocketProtocolEnabled to LayoutTestController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||
| Component: | Tools / Tests | Assignee: | Yuta Kitamura <yutak> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | abarth, tkent | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 50099 | ||||||
| Attachments: |
|
||||||
|
Description
Yuta Kitamura
2011-06-28 07:23:20 PDT
Created attachment 98916 [details]
Patch
Comment on attachment 98916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98916&action=review > Tools/ChangeLog:8 > + Add a method to LayoutTestController so we can switch WebSocket protocols in layout tests. Why don't you use window.internals? See WebCore/testing/Internals.* Comment on attachment 98916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98916&action=review Taking Adam's advice, I would like to use LayoutTestController::overridePreference(), rather than adding a new method to LayoutTestController. I'm preparing a new patch. >> Tools/ChangeLog:8 >> + Add a method to LayoutTestController so we can switch WebSocket protocols in layout tests. > > Why don't you use window.internals? > See WebCore/testing/Internals.* I don't think I can use window.internals for this purpose, because we need to reset preference values for each test run to prevent preference values from previous runs from leaking to the following tests. |