Bug 63515

Summary: AtomicString::show() and WTFString::show() should be const.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2011-06-28 00:03:35 PDT
AtomicString::show() and WTFString::show are not const, so we have to use const_cast to call them occasionally. These methods should be const.
Attachments
Patch (2.80 KB, patch)
2011-06-28 00:11 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2011-06-28 00:48 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2011-06-28 00:11:35 PDT
Created attachment 98870 [details] Patch
Kent Tamura
Comment 2 2011-06-28 00:14:58 PDT
(In reply to comment #0) > AtomicString::show() and WTFString::show are not const, so we have to use const_cast to call them occasionally. So you should remove such const_casts in this patch. Otherwise, the patch has no benefit.
Shinya Kawanaka
Comment 3 2011-06-28 00:37:43 PDT
Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. This bug is related to https://bugs.webkit.org/show_bug.cgi?id=61149
Kent Tamura
Comment 4 2011-06-28 00:40:20 PDT
(In reply to comment #3) > Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. Ok, I understand. Please note such reasons to ChangeLog.
Shinya Kawanaka
Comment 5 2011-06-28 00:48:31 PDT
Created attachment 98875 [details] Patch
Kent Tamura
Comment 6 2011-06-28 00:50:10 PDT
Comment on attachment 98875 [details] Patch ok.
WebKit Review Bot
Comment 7 2011-06-28 01:54:11 PDT
Comment on attachment 98875 [details] Patch Clearing flags on attachment: 98875 Committed r89906: <http://trac.webkit.org/changeset/89906>
WebKit Review Bot
Comment 8 2011-06-28 01:54:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.