Summary: | AtomicString::show() and WTFString::show() should be const. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Shinya Kawanaka
2011-06-28 00:03:35 PDT
Created attachment 98870 [details]
Patch
(In reply to comment #0) > AtomicString::show() and WTFString::show are not const, so we have to use const_cast to call them occasionally. So you should remove such const_casts in this patch. Otherwise, the patch has no benefit. Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. This bug is related to https://bugs.webkit.org/show_bug.cgi?id=61149 (In reply to comment #3) > Since this is a debug feature, there is no code to call show() in Sources (maybe). However, when doing something like printf-debug, the lack of const is painful. Ok, I understand. Please note such reasons to ChangeLog. Created attachment 98875 [details]
Patch
Comment on attachment 98875 [details]
Patch
ok.
Comment on attachment 98875 [details] Patch Clearing flags on attachment: 98875 Committed r89906: <http://trac.webkit.org/changeset/89906> All reviewed patches have been landed. Closing bug. |