|Summary:||Selection shouldn't exclude collapsed whitespace|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||HTML Editing||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||emacemac7, eric, evan, ian, michael.vm|
|OS:||OS X 10.4|
|Bug Depends on:||23793|
Description Alexey Proskuryakov 2006-01-03 03:29:54 PST
If a selection range set via setBaseAndExtent starts or ends with collapsed whitespace, it is excluded from the range, which doesn't happen in Firefox.
Comment 2 Justin Garcia 2006-01-04 01:23:55 PST
Here's why this happens: Positions passed to Selection::setBaseAndExtent are used to construct VisiblePositions. VisiblePositions take the input position and find its canonical position: the position that is visually equivalent but "deep" and at a rendered offset (this canonical position is referred to internally as a "deep equivalent" and is returned by VisiblePosition::deepEquivalent()) For example: <div><b>hello world</b></div> A VisiblePosition created with the Position (div, 0), would have a "deep equivalent" of (textnode, 0). A VisiblePosition created with the Positions (textnode, 6), (textnode, 7), and (textnode, 8) would all have deep equivalents of (textnode, 8). The behavior you see is caused because SelectionController takes the Positions passed to setBaseAndExxtent, creates VisiblePositions, then sets the base and the extent to the deep equivalents of those VisiblePositions. SelectionController does even more fiddling with its positions. When it creates start/end (from base/ extent), it upstream()s the end and downstream()s the start. Comments in SelectionController claim that this is necessary to "constrain" the selection to the fewest possible nodes, in order to make it canonical for purposes of comparison with other selections. I'm not sure why this is necessary, since VisiblePosition's are already canonical. Both of these things need to be addressed to fix this kind of bug (when ranges change when they are used to make selections).