| Summary: | Use specific headers includes rather than full system headers. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||
| Component: | New Bugs | Assignee: | Alexis Menard (darktears) <menard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric.carlson, sam, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexis Menard (darktears)
2011-06-27 13:14:57 PDT
Created attachment 98773 [details]
Patch
Comment on attachment 98773 [details]
Patch
Is there a concrete benefit to this change? I ask, because due to the way precompiled headers and such work, the other teams at Apple have told us that best practice is to include the complete header, not the specific headers, for system frameworks like these.
(In reply to comment #2) > (From update of attachment 98773 [details]) > Is there a concrete benefit to this change? I ask, because due to the way precompiled headers and such work, the other teams at Apple have told us that best practice is to include the complete header, not the specific headers, for system frameworks like these. Quoting Sam Weinig who send me an email : "The inclusion of <Cocoa/Cocoa.h> in header files seems really suspect here. I have been trying to remove as many full system header inclusions as possible, and this seems like a step in the wrong direction." Comment on attachment 98773 [details]
Patch
OK. If Sam says this is the right thing to do, I guess that’s OK.
Comment on attachment 98773 [details] Patch Clearing flags on attachment: 98773 Committed r89858: <http://trac.webkit.org/changeset/89858> All reviewed patches have been landed. Closing bug. |