Bug 63455

Summary: Web Inspector: console group boundaries should be more distinct in UI
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, me, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Screenshot with the patch applied none

Description Yury Semikhatsky 2011-06-27 08:03:28 PDT
Sometimes it is hard to say whether a message belongs to an expanded group or not. We should make group boundaries more clear in console.

Original user request: http://stackoverflow.com/questions/6432925/is-the-firebug-chromedevtools-console-group-indentation-wrong
and http://groups.google.com/group/google-chrome-developer-tools/browse_thread/thread/978cd86cf0d63f24#
Comment 1 Jeremy A. Prescott 2011-06-27 16:53:38 PDT
an idea would be to reuse the users specified name of console.group("someName") and let the user (optionally) tell which group should be closed with endGroup. Exmpl; endGroup("someName").
This would for sure lead to some unexpected behavior for new devs, but would give more power to experienced devs dealing with callbacks/ajax/json-p trickery.
Comment 2 Yury Semikhatsky 2011-06-28 01:17:54 PDT
Created attachment 98879 [details]
Patch
Comment 3 Yury Semikhatsky 2011-06-28 01:18:27 PDT
Created attachment 98880 [details]
Screenshot with the patch applied
Comment 4 Yury Semikhatsky 2011-06-28 01:21:38 PDT
(In reply to comment #1)
> an idea would be to reuse the users specified name of console.group("someName") and let the user (optionally) tell which group should be closed with endGroup. Exmpl; endGroup("someName").
> This would for sure lead to some unexpected behavior for new devs, but would give more power to experienced devs dealing with callbacks/ajax/json-p trickery.

This would complicate semantics of groupEnd. On the other hand described functionality can be easily implemented based on the existing console.group/groupEnd by introducing a stack of opened group names.
Comment 5 Pavel Feldman 2011-06-28 02:24:05 PDT
Comment on attachment 98879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98879&action=review

> Source/WebCore/inspector/front-end/inspector.css:711
> +    left: -14px;

Nice
Comment 6 Yury Semikhatsky 2011-06-28 02:26:44 PDT
Committed r89911: <http://trac.webkit.org/changeset/89911>