Bug 63441

Summary: [EFL] Remove unnecessary header files from EWebKit_HEADERS.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-06-27 03:13:44 PDT
Now, all header files except ewk_private.h are included as header files. However, I think 1. ewk_tiled_private.h is not public. 2. functions should not be public API, which are in ewk_tiled_backing_store.h and ewk_tiled_matrix.h. And ewk_auth_soup.h should be installed when libsoup is enabled.
Attachments
Patch (1.83 KB, patch)
2011-06-27 03:33 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-06-27 03:33:55 PDT
Created attachment 98695 [details] Patch
Gyuyoung Kim
Comment 2 2011-06-27 03:40:20 PDT
Informal r+ on my side.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-06-27 06:31:24 PDT
Informal r+ from my side.
WebKit Review Bot
Comment 4 2011-06-27 07:36:19 PDT
Comment on attachment 98695 [details] Patch Clearing flags on attachment: 98695 Committed r89818: <http://trac.webkit.org/changeset/89818>
WebKit Review Bot
Comment 5 2011-06-27 07:36:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.