Bug 63404

Summary: [GTK] Allow to build WebKitGtk+ with accelerated compositing
Product: WebKit Reporter: Joone Hur <joone.hur>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gns, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Proposed Patch
mrobinson: review-
Proposed Patch2 none

Description Joone Hur 2011-06-26 10:14:47 PDT
WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms and animation through GPU acceleration.
First, we need to build WebKitGtk+ with accelerated composting by default although it wouldn't work.
Comment 1 Joone Hur 2011-06-26 18:37:55 PDT
Created attachment 98652 [details]
Proposed Patch
Comment 2 Martin Robinson 2011-06-27 09:17:50 PDT
Comment on attachment 98652 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98652&action=review

> Source/JavaScriptCore/wtf/Platform.h:1138
> +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) &&!defined(WIN_CAIRO)) || PLATFORM(EFL) || PLATFORM(GTK)

I don't think we should turn it on by default until it's implemented. The other parts of this change look good.
Comment 3 Joone Hur 2011-06-28 01:02:22 PDT
Created attachment 98877 [details]
Proposed Patch2

I've updated the patch.
Thanks, Martin.
Comment 4 WebKit Review Bot 2011-06-28 09:28:02 PDT
Comment on attachment 98877 [details]
Proposed Patch2

Clearing flags on attachment: 98877

Committed r89937: <http://trac.webkit.org/changeset/89937>
Comment 5 WebKit Review Bot 2011-06-28 09:28:22 PDT
All reviewed patches have been landed.  Closing bug.