SVGAnimatedType should support SVGLengthList animation

• Component: SVG
• Status: RESOLVED FIXED

[Dirk Schulze]

SVGAnimatedType should support SVGLengthList animation

[Dirk Schulze]

Created attachment 98638 [details]
Patch

[WebKit Review Bot]

Attachment 98638 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1

Source/WebCore/svg/SVGAnimatedLengthList.cpp:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:54:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:54:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.cpp:77:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:50:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:50:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:51:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:51:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedLengthList.h:53:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGLength.h:73:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/svg/SVGLength.h:73:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 16 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nikolas Zimmermann]

Comment on attachment 98638 [details]
Patch

Dirk, I love your pace :-) r=me. How many are left? AnimBool? AnimEnum? AnimTrafoList?

[Dirk Schulze]

Committed r89783: <http://trac.webkit.org/changeset/89783>

[Csaba Osztrogonác]

SVG animation pause API is missing in WebKit2, and we always have to add new tests to mac-wk2/Skipped list because of this bug. Guys, could you add this kind of tests automatically to the Skipped list when you add a new test, please?

[WK2] SVG animation pause API missing
 https://bugs.webkit.org/show_bug.cgi?id=63396

[Nikolas Zimmermann]

(In reply to comment #5)
> SVG animation pause API is missing in WebKit2, and we always have to add new tests to mac-wk2/Skipped list because of this bug. Guys, could you add this kind of tests automatically to the Skipped list when you add a new test, please?
> 
> [WK2] SVG animation pause API missing
>  https://bugs.webkit.org/show_bug.cgi?id=63396

Dirk, please remember this when landing the next one!