Bug 63383

Summary:

Don't check dangling icon database urls in release build if not pruning entries.

Product:

WebKit

Reporter:

Lukasz Slachciak <l.slachciak>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

beidson, eric, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Dangling fix	beidson: review-

Lukasz Slachciak

Reported 2011-06-25 12:44:49 PDT

This fixes checkForDanglingPageURLs mechanism. Logic described in comment to function code is not correspondent to the code which executes SQLiteStatement in Release build even if pruning is not requested. This fix will cause that after writing to Icon database and calling checkForDanglingPageURLs(false) unneded database query will not be executed (in Release build) In simple words: Release build was incorrectly recognised.

Attachments
Dangling fix (2.07 KB, patch) 2011-06-25 12:48 PDT, Lukasz Slachciak	beidson: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Lukasz Slachciak

Comment 1 2011-06-25 12:48:35 PDT

Created attachment 98597 [details] Dangling fix

Eric Seidel (no email)

Comment 2 2011-09-12 15:49:53 PDT

Brady is the IconDB guy. I guess he's not reading his mail?

Eric Seidel (no email)

Comment 3 2012-02-16 14:01:53 PST

I emailed beidson directly just now.

Brady Eidson

Comment 4 2012-02-16 16:07:08 PST

Comment on attachment 98597 [details] Dangling fix This patch doesn't make things correct. The code changed in this patch does indeed follow what the comment says. The real fix is in the if statement: if ((pruneIfFound || !danglersFound) && SQLiteStatement(m_syncDB, "SELECT url FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT 1;").returnsAtLeastOneResult()) should become... if (pruneIfFound && (danglersFound || SQLiteStatement(m_syncDB, "SELECT url FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT 1;").returnsAtLeastOneResult()))

Note You need to log in before you can comment on or make changes to this bug.