Bug 63373 – REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors

• Component: CSS
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

Originally reported here: http://crbug.com/86595

Turns out, when building a parent stack frame in CSSStyleSelector, we inadvertently empty out the identifier list for all shadow DOM elements. The fix is to employ shadow DOM-aware traversal, rather than using parentElement.

[Dimitri Glazkov (Google)]

Created attachment 98572 [details]
Patch

[WebKit Review Bot]

Comment on attachment 98572 [details]
Patch

Attachment 98572 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8936642

New failing tests:
fast/css/pseudo-cache-stale.html

[WebKit Review Bot]

Created attachment 98574 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dimitri Glazkov (Google)]

Comment on attachment 98572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98572&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:669
> +    } else if (!parent->parentOrHostNode()) {

This should've been parentOrHostElement. Fixed on landing.

[Dimitri Glazkov (Google)]

Committed r89742: <http://trac.webkit.org/changeset/89742>