Bug 63372

Summary: convert editing/deleting/whitespace-pre-1.html to dumpAsText
Product: WebKit Reporter: Wyatt Carss <wcarss>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: jparent, ojan, rniwa, tony, wcarss, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Wyatt Carss
Reported 2011-06-24 18:09:23 PDT
convert editing/deleting/whitespace-pre-1.html to dumpAsText
Attachments
Patch (76.71 KB, patch)
2011-06-24 18:12 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (77.20 KB, patch)
2011-06-27 12:11 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wyatt Carss
Comment 1 2011-06-24 18:12:08 PDT
Created attachment 98570 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-24 18:53:28 PDT
Comment on attachment 98570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98570&action=review > LayoutTests/editing/deleting/whitespace-pre-1.html:4 > if (window.layoutTestController) > layoutTestController.dumpEditingCallbacks(); > + layoutTestController.dumpAsText(); You need curly brackets around these two statements. Otherwise, we'll get script errors when we run it manually on a browser. Also I'd use dump-as-markup.js to see the markup.
Wyatt Carss
Comment 3 2011-06-27 12:11:24 PDT
Created attachment 98764 [details] Patch
WebKit Review Bot
Comment 4 2011-06-27 14:38:51 PDT
Comment on attachment 98764 [details] Patch Clearing flags on attachment: 98764 Committed r89862: <http://trac.webkit.org/changeset/89862>
WebKit Review Bot
Comment 5 2011-06-27 14:38:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.