Summary: | nrwt: remove --use-apache from the command line | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, jamesr, mihaip, ojan, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dirk Pranke
2011-06-24 15:13:24 PDT
Created attachment 98549 [details]
Patch
Comment on attachment 98549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98549&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:848 > + """Override if your port uses something other than Apache for serving > + web pages.""" I'd skip this docstring > Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py:58 > + USES_APACHE = False This appears to be unused. Committed r90503: <http://trac.webkit.org/changeset/90503> Reverted r90503 for reason: Makes Chromium Windows canary bots hang Committed r90514: <http://trac.webkit.org/changeset/90514> Created attachment 99914 [details]
Patch
Comment on attachment 99914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99914&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:234 > + return self._executive.run_command([path, "-v"], env=env, return_exit_code=True) == 0 This change fixes the hang on windows. Note that I had to add the env keyword param to executive.run_command() for this to work. Comment on attachment 99914 [details]
Patch
no unit tests added for executive.run_command, although there probably should be one. I didn't add a test for this chromium_win either, because it would involve a bunch of mocking and I was feeling lazy.
Comment on attachment 99914 [details]
Patch
Ok.
Comment on attachment 99914 [details] Patch Clearing flags on attachment: 99914 Committed r90527: <http://trac.webkit.org/changeset/90527> All reviewed patches have been landed. Closing bug. Added = TIMEOUT lines to test_expectations in http://trac.webkit.org/changeset/90718 Adding those = TIMEOUT lines seemed to just make a different set of tests time out, so I removed those. At this point I'm suspecting an issue with the bot (http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win7) but I'm not able to do anything about it right now. (In reply to comment #13) > Adding those = TIMEOUT lines seemed to just make a different set of tests time out, so I removed those. Note that's because of the --exit-after-n-crashes-or-timeouts flag, which meant that we stopped running tests after 20 unexpected timeouts. re-closing this. |