Bug 6334

Summary:

REGRESSION: <input type="button"> text is reversed on "visual Hebrew" pages

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

VERIFIED FIXED

Severity:

Normal

CC:

alice.barraclough

Priority:

Keywords:

InRadar

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Testcase	none
Add rtl-ordering CSS property and override it for form buttons	none
Add rtl-ordering CSS property and override it for form buttons	none
Add rtl-ordering CSS property and override it for form buttons	none
Updated patch	darin: review+

mitz

Reported 2006-01-02 07:40:23 PST

The new button code renders <input type="button"> text on "visual Hebrew" pages as if it was visually ordered. However, input-button text is in logical order even on "visual" pages. The result is that text is reversed. Note that <button> text is in visual order on "visual" pages. To reproduce, open the attached testcase in Safari w/TOT WebKit. Expected: the text on both buttons to look like the example. WinIE renders as expected. Firefox gets the top button wrong. Actual: the text on the bottom button is reversed. This is a regression from release Safari, where both <input> and <button> text appear correctly, as they do in WinIE. I think a possible fix is to expose the visuallyOrdered private CSS property and override it for input- buttons in html4.css.

Attachments
Testcase (227 bytes, text/html) 2006-01-02 07:40 PST, mitz	no flags	Details
Add rtl-ordering CSS property and override it for form buttons (11.09 KB, patch) 2006-01-03 23:52 PST, mitz	no flags	Details Formatted Diff Diff
Add rtl-ordering CSS property and override it for form buttons (12.15 KB, patch) 2006-01-05 09:01 PST, mitz	no flags	Details Formatted Diff Diff
Add rtl-ordering CSS property and override it for form buttons (13.71 KB, patch) 2006-01-06 08:23 PST, mitz	no flags	Details Formatted Diff Diff
Updated patch (12.20 KB, patch) 2006-01-11 11:52 PST, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-01-02 07:40:58 PST

Created attachment 5422 [details] Testcase

Darin Adler

Comment 2 2006-01-02 18:31:25 PST

Nice idea about how to fix this.

mitz

Comment 3 2006-01-03 23:52:55 PST

Created attachment 5470 [details] Add rtl-ordering CSS property and override it for form buttons

mitz

Comment 4 2006-01-03 23:56:55 PST

Comment on attachment 5470 [details] Add rtl-ordering CSS property and override it for form buttons Can someone suggest better names for the property and its values?

Darin Adler

Comment 5 2006-01-04 13:07:27 PST

Comment on attachment 5470 [details] Add rtl-ordering CSS property and override it for form buttons Looks fine, r=me. I think -khtml-rtl-ordering is a fine name for this.

Alexey Proskuryakov

Comment 6 2006-01-05 03:43:35 PST

Applying this patch has changed the results of fast/inspector/style.html for me: -background-attachment: initial (original property was background) -background-position-x: initial (original property was background) -background-position-y: initial (original property was background) +background-attachment: null +background-position-x: null +background-position-y: null

mitz

Comment 7 2006-01-05 06:19:08 PST

Sorry! Thanks, Alexey.

mitz

Comment 8 2006-01-05 09:01:36 PST

Created attachment 5497 [details] Add rtl-ordering CSS property and override it for form buttons fast/inspector/style.html failed because the makeprop script was using the length of the last property in cssproperties.in (which this patch changes) as the maximum property length.

mitz

Comment 9 2006-01-05 09:02:48 PST

Comment on attachment 5497 [details] Add rtl-ordering CSS property and override it for form buttons Added fix for the max propertly length bug in makeprop.

Darin Adler

Comment 10 2006-01-05 09:46:35 PST

Comment on attachment 5497 [details] Add rtl-ordering CSS property and override it for form buttons Good catch in makeprop!

mitz

Comment 11 2006-01-06 07:27:10 PST

Comment on attachment 5497 [details] Add rtl-ordering CSS property and override it for form buttons ...and Alexey saves me (and SVG) from myself again.

mitz

Comment 12 2006-01-06 08:23:06 PST

Created attachment 5513 [details] Add rtl-ordering CSS property and override it for form buttons The numbers of CSS properties and values in KHTML is hard-coded in the KSVG scripts. I'm sure it doesn't have to be this way, but for now, this just updates the numbers to the correct values.

Alice Liu

Comment 13 2006-01-09 16:34:21 PST

<rdar://problem/4403696>

mitz

Comment 14 2006-01-11 11:52:32 PST

Created attachment 5606 [details] Updated patch As Eric suggested on IRC, I simply changed SVG properties and values to start after 10000. I think it's completely safe.

Darin Adler

Comment 15 2006-01-11 12:20:23 PST

Comment on attachment 5606 [details] Updated patch Looks good. r=me

mitz

Comment 16 2006-01-13 03:15:38 PST

Visual Hebrew is so embarrassing :-}

Joost de Valk (AlthA)

Comment 17 2006-01-22 04:57:06 PST

Removing keyword(s) since bug is fixed.

Note You need to log in before you can comment on or make changes to this bug.