Bug 63281 – TestFailures page fetches build JSON for every build, which is slow and limits history to the last build master restart

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

TestFailures page fetches build JSON for every build, in addition to the results.html page. It does this so it can determine whether run-webkit-tests exited early due to too many failures/crashes/timeouts. But this is slow, and limits history to whenever the build master was last restarted.

It would be much better if we could just pull this information out of results.html. Then we'd only have to do one request per build, and history would be practically unlimited.

[Adam Roben (:aroben)]

After bug 63280 is fixed, we can change TestFailures to only look at the build JSON if we're dealing with a build older than whatever revision bug 63280 was fixed in.

[Adam Roben (:aroben)]

Created attachment 98404 [details]
Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

[David Kilzer (:ddkilzer)]

Comment on attachment 98404 [details]
Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:75
> +    resultsHTMLForBuildIncludesTooManyFailuresInfo: function(buildName) {

See next comment.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247
> +        var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName);

I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures.  How about using "Supports" instead of "Includes"?

var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName);

[Adam Roben (:aroben)]

Comment on attachment 98404 [details]
Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247
>> +        var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName);
> 
> I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures.  How about using "Supports" instead of "Includes"?
> 
> var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName);

Good suggestion. I'll go with that!

[Adam Roben (:aroben)]

Committed r89619: <http://trac.webkit.org/changeset/89619>