Summary: | TestFailures page fetches build JSON for every build, which is slow and limits history to the last build master restart | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://build.webkit.org/TestFailures/ | ||||||
Bug Depends on: | 63280 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-06-23 13:22:31 PDT
After bug 63280 is fixed, we can change TestFailures to only look at the build JSON if we're dealing with a build older than whatever revision bug 63280 was fixed in. Created attachment 98404 [details]
Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early
Comment on attachment 98404 [details] Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:75 > + resultsHTMLForBuildIncludesTooManyFailuresInfo: function(buildName) { See next comment. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247 > + var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName); I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures. How about using "Supports" instead of "Includes"? var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName); Comment on attachment 98404 [details] Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:247 >> + var resultsHTMLIncludesTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName); > > I don't like "Includes" in this variable name because that implies (just reading the variable name) that this particular build has info about too many failures. How about using "Supports" instead of "Includes"? > > var resultsHTMLSupportsTooManyFailuresInfo = this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName); Good suggestion. I'll go with that! Committed r89619: <http://trac.webkit.org/changeset/89619> |