Bug 63261

Summary: [X11][WK2] plugins/npp-set-window-called-during-destruction.html fails
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Balazs Kelemen <kbalazs>
Status: NEW    
Severity: Normal CC: cgarcia, kling, mrobinson
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch none

Balazs Kelemen
Reported 2011-06-23 09:50:47 PDT
Diff: +CONSOLE MESSAGE: line 0: PLUGIN: Fail: NPP_SetWindow called more than once before plugin destruction CONSOLE MESSAGE: line 0: PLUGIN: Success: NPP_SetWindow was called during plugin destruction This tests whether a NPP_SetWindow is called during plugin destruction.
Attachments
Patch (2.87 KB, patch)
2011-06-23 09:57 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-06-23 09:57:43 PDT
Created attachment 98361 [details] Patch
Balazs Kelemen
Comment 2 2011-06-24 16:57:29 PDT
After http://trac.webkit.org/changeset/89678 the test will fail even with the patch.
Balazs Kelemen
Comment 3 2011-06-25 10:37:32 PDT
I see two ways to fix the test: 1. make the behavior consistent across wk1/wk2 by not calling SetWindow for any plugin in wk1, and change the test to output "Pass" when it is not called like it does on Mac (i.e. changing the "#if XP_MACOSX" in NPPSetWindowCalledDuringDestruction.cpp to "#if XP_MACOSX || XP_UNIX"). 2. add expected failing result to the wk2 expectation directory The patch is outdated now so I just keep the r? because I need some feedback.
Balazs Kelemen
Comment 4 2011-07-01 08:01:31 PDT
Do you guys think we should fix this? If so, do you like one of my suggestions or have you got some better idea?
Balazs Kelemen
Comment 5 2011-08-25 01:14:59 PDT
Andreas, please revive this dead thread with your opinion!
Note You need to log in before you can comment on or make changes to this bug.