Bug 63259 – Warnings in JSC's JIT on 32 bit

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Pierre Rossi]

preventing from building with -Werror.

[Pierre Rossi]

Created attachment 98355 [details]
patch

[Gavin Barraclough]

Comment on attachment 98355 [details]
patch

looks great!

[WebKit Review Bot]

Comment on attachment 98355 [details]
patch

Rejecting attachment 98355 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
atching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp
Hunk #1 succeeded at 131 (offset -94 lines).
Hunk #2 FAILED at 436.
Hunk #3 succeeded at 411 (offset -103 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'..." exit_code: 1

Full output: http://queues.webkit.org/results/8935128

[Pierre Rossi]

Created attachment 98407 [details]
rebased

oops, that patch was based on qtwebkit-2.2 branch...

[WebKit Review Bot]

Comment on attachment 98407 [details]
rebased

Clearing flags on attachment: 98407

Committed r89985: <http://trac.webkit.org/changeset/89985>

[Ademar Reis]

(In reply to comment #4)
> Created an attachment (id=98407) [details]
> rebased
> 
> oops, that patch was based on qtwebkit-2.2 branch...

Just out of curiosity: could you please explain how can I reproduce the warning? Using Linux (Fedora 13 32bits) -W -Wall -Werror I can build it without any problems... Maybe my g++ (v4.4.5) is too old?

[Pierre Rossi]

(In reply to comment #6)
> (In reply to comment #4)
> > Created an attachment (id=98407) [details] [details]
> > rebased
> > 
> > oops, that patch was based on qtwebkit-2.2 branch...
> 
> Just out of curiosity: could you please explain how can I reproduce the warning? Using Linux (Fedora 13 32bits) -W -Wall -Werror I can build it without any problems... Maybe my g++ (v4.4.5) is too old?


Mhhh, could it be that you're building in debug maybe? As far as I can remember I was getting plain unused variable warnings.

[Ademar Reis]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > Created an attachment (id=98407) [details] [details] [details]
> > > rebased
> > > 
> > > oops, that patch was based on qtwebkit-2.2 branch...
> > 
> > Just out of curiosity: could you please explain how can I reproduce the warning? Using Linux (Fedora 13 32bits) -W -Wall -Werror I can build it without any problems... Maybe my g++ (v4.4.5) is too old?
> 
> 
> Mhhh, could it be that you're building in debug maybe? As far as I can remember I was getting plain unused variable warnings.

I'm building in release mode, so I guess it's my g++.

Anyway, your patch looks good and is simple enough, will cherry-pick it into qtwebkit-2.2