Bug 63255 – [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

http://build.webkit.org/results/Qt%20Linux%20Release/r89506%20%2834502%29/results.html

[Csaba Osztrogonác]

I skipped the failing tests: http://trac.webkit.org/changeset/89569

But it doesn't solve the real bug which should be fixed or the original patch should be rolled out.

[Nate Chapin]

r89503 changed the timings of the callback that tells the embedder that a load is complete.  From the layout test diffs you linked, it looks like the notifications aren't being completed before the test finishes and the next one starts.

Feel free to grab me on IRC if there's anything I can do to help with this.

[Yael]

Ossy, since r89503 was mostly reverted, should we unskip the notifications tests?

[Csaba Osztrogonác]

(In reply to comment #3)
> Ossy, since r89503 was mostly reverted, should we unskip the notifications tests?

They were unskipped (accidentally :)) ): http://trac.webkit.org/changeset/89732/trunk/LayoutTests/platform/qt/Skipped

[Andras Becsi]

The tests started to fail again after http://trac.webkit.org/changeset/90471:

fast/notifications/notifications-no-icon.html (flaky)
fast/notifications/notifications-double-show.html
fast/notifications/notifications-with-permission.html
fast/notifications/notifications-without-permission.html

Skipped tests in http://trac.webkit.org/changeset/90570 and reopening the bug.

http://build.webkit.org/results/Qt%20Linux%20Release/r90560%20(35105)/results.html

[Yael]

Before http://trac.webkit.org/changeset/89569, we would wait for the notification icon to load before transitioning to committed state, and the test had enough time to complete. With http://trac.webkit.org/changeset/89569, we transition to committed state before the load is finished, thus the tests are failing.

I think the behavior of Notifications is still correct, but the tests need to be modified, so that they wait for the icon to finish loading.

I am preparing a patch for that.

[Yael]

Created attachment 100144 [details]
Patch

Modified the tests to wait until icon loading is finished.

[Csaba Osztrogonác]

Comment on attachment 100144 [details]
Patch

LGTM, r=me

[WebKit Review Bot]

Comment on attachment 100144 [details]
Patch

Rejecting attachment 100144 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 423, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 479, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9013318

[Csaba Osztrogonác]

(In reply to comment #9)
> (From update of attachment 100144 [details])
> Rejecting attachment 100144 [details] from commit-queue.
> 
> Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1
> 
> Last 500 characters of output:
> cripts/webkitpy/common/system/executive.py", line 423, in run_command
>     close_fds=self._should_close_fds())
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 479, in popen
>     return subprocess.Popen(*args, **kwargs)
>   File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
>     errread, errwrite)
>   File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
>     raise child_exception
> TypeError: execv() arg 2 must contain only strings
> 
> Full output: http://queues.webkit.org/results/9013318

CQ still hates my name. :(( Could you land it manually?

[WebKit Review Bot]

Comment on attachment 100144 [details]
Patch

Rejecting attachment 100144 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 423, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 479, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9014194

[Yael]

Committed r90471: <http://trac.webkit.org/changeset/90741>