Bug 63240 – [EFL] Put bg_rect object under the backing store

• Component: WebKit EFL
• Status: RESOLVED INVALID

[KwangHyuk]

Basic implementation to support backgrounds for areas not rendered yet and zoom animation (weak zoom).

[KwangHyuk]

Created attachment 98328 [details]
propose a simple patch

[Gyuyoung Kim]

Could you explain why you need this patch ?

[KwangHyuk]

First, As the most of content’s size is not corresponding to the viewport, while zooming content’s bottom side is cut and it looks little ugly.
Second, There would be no tile rendered when backing store is working, background color can give better feeling than transparent one.
And finally, zoom bounce implementation also requires bg_rect object since it can fill the bottom side of the scaled content while it is working with the smaller zoom level than 1.0x.

[KwangHyuk]

As for the zoom bounce feature, It would be added as soon as some apis are ready.

[Gyuyoung Kim]

LGTM.

[Ryuan Choi]

View in context: https://bugs.webkit.org/attachment.cgi?id=98328&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:738
> +    evas_object_color_set(o, 255, 255, 255, 255);

How can we get transparent webview?
Should we need to consider behavior of ewk_view_bg_color_set?

[KwangHyuk]

> How can we get transparent webview?
> Should we need to consider behavior of ewk_view_bg_color_set?

Make sense, :-)

[KwangHyuk]

>> How can we get transparent webview?
>> Should we need to consider behavior of ewk_view_bg_color_set?

> Make sense, :-)

As for this, I better add some implementation into ewk_view_bg_color_set as new patch and will follow it up too if there is no objection to modify that api.

[Lucas De Marchi]

(In reply to comment #3)
> First, As the most of content’s size is not corresponding to the viewport, while zooming content’s bottom side is cut and it looks little ugly.
> Second, There would be no tile rendered when backing store is working, background color can give better feeling than transparent one.
> And finally, zoom bounce implementation also requires bg_rect object since it can fill the bottom side of the scaled content while it is working with the smaller zoom level than 1.0x.

This doesn't belong to WebKit. It could be perfectly done in the browser as eve does.

Eric Seidel already noticed once that sometimes the EFL port does things that should be rather implemented in the browser. So, let's try not to bloat our API.

Informal r- on my side.

[KwangHyuk]

Make sense.

But, I would like to add my idea more.

From the point of api view, I won’t add new api for this bounce feature.

I would like to know whether you still think that this bounce feature would be in application area although I won’t add new api for this feature ?

In addition, I think that it would be nice if webview can support zoom bounce feature by itself, by considering rectangle ratio between view port and content size.

I will appreciate you if you share your idea more for this.

[KwangHyuk]

Hi, Lucas,

I will discuss with ui developer whether he can take bg rect and apply it into application side.
Would you share your idea one more time whether you are really thinking that bg rect can't be a part of ewk_view ?

[KwangHyuk]

I close this bug. :-)