Bug 63202
| Summary: | webkitEnterFullscreen should not require user gesture if mediaPlaybackRequiresUserAction is false | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam <adamjernst> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adam
Calling .webkitEnterFullscreen() will raise INVALID_STATE_ERR except from a user-initiated gesture. If document()->settings()->mediaPlaybackRequiresUserAction() is false, I believe webkitEnterFullscreen should be allowed without a user gesture.
The machinery behind the gesture requirement for webkitEnterFullscreen is roughly the same as that behind the load() and play() restrictions requiring a user-initiated gesture. The mediaPlaybackRequiresUserAction property was added for the express purpose of letting users disable these restrictions (which we do in our iOS app's UIWebView).
mediaPlaybackRequiresUserAction is mapped into a corresponding "BehaviorRestrictionFlag" on HTMLMediaElement. (See WebCore sources/html/HTMLMediaElement.h.) This is checked in play() and load().
Adapting webkitEnterFullscreen accordingly would be a relatively small change: a new BehaviorRestrictionFlag set accordingly and updating HTMLVideoElement::webkitEnterFullscreen to check it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam
Disregard, dupe of https://bugs.webkit.org/show_bug.cgi?id=55239
*** This bug has been marked as a duplicate of bug 55239 ***